Add beat snap grid to osu!taiko editor #25154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Oct 17, 2023
Comment on lines
+126
to
+127
| if (DrawableRuleset is IDrawableScrollingRuleset scrollingRuleset) | ||
| dependencies.CacheAs(scrollingRuleset.ScrollingInfo); |
There was a problem hiding this comment.
This is another example: if you have to use soft casts to subclasses in the base class, then that's a strong sign that maybe the logic should live in the subclass to begin with.
There was a problem hiding this comment.
Or that we shouldn't have subclasses in the first place and should use this pattern more often, I dunno. Hierarchy has been pretty restrictive in these kinds of usages.
There was a problem hiding this comment.
I'm gonna look away from this one for the time being because I kind of want to try and switch the scrolling stuff to composition too at some point. And it's not even precedent (see FindSnappedPositionAndTime()).
bdach
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25150.
I did notice a performance issue when selecting all objects in a beatmap:
But it's not a regression in this PR, and it's not that bad (non-crippling performance, just a stutter while 2.5k barlines are created).
CleanShot.2023-10-17.at.07.57.54.mp4