Adjust gameplay element maximum size limits for backwards compatibility #25023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the maximum allowable element sizes enforced in #24706 such that they affect a significantly smaller number of user skins.
The new limits were chosen by sampling across over 4000 skins, using data graciously provided by @RockRoller01. The methodology for doing so is described in this gist.
The nominal goals were:
The table below contains the full breakdown:
hitcircle
sliderstartcircle
sliderendcircle
hitcircleoverlay
sliderstartcircleoverlay
sliderendcircleoverlay
reversearrow
sliderb
sliderb-nd
sliderb-spec
sliderfollowcircle
default-N
taikohitcircle
taikobigcircle
taikohitcircleoverlay
taikobigcircleoverlay
fruit-{bananas,pear,grapes,apple,orange}
fruit-{bananas,pear,grapes,apple,orange}-overlay
fruit-drop
fruit-drop-overlay
All dimensions are
@1x
.@2x
elements are still allowed to be twice as big as limits above.