Skin inconsistency between release and master

[Theighlin]

Type

Game behaviour

Bug description

These screenshot were used using the same folder (i renamed osu-development to osu and ran release, not logged in)

Screenshots or videos

2023.924.1	master

Skins: https://osu.ppy.sh/community/forums/topics/1792308?n=1
https://drive.google.com/file/d/1t6-Hfz5mG4IxATLjLcAGmyEEshZob_kp/view?usp=sharing
(i imagine any beatmap will do, but here we go) Beatmap: https://osu.ppy.sh/beatmapsets/1760668#osu/4036420

Version

09c9baa

Logs

performance.log
runtime.log
database.log
input.log

[frenzibyte]

This is one of the after-effects of #24706, will investigate further.

[frenzibyte]

#24975 should fix the incorrect rendering of the glyphs in the first screenshots row. For the hit circles, they look to be over the size of the hit circle's dimensions for the drop-shadow effect:

With #24975, it will render as follows:

We could add bit more leniency to the hit circle's maximum dimensions to allow for such effects, maybe an absolute number applied within WithMaximumSize itself. @peppy thoughts?

[frenzibyte]

To keep this thread updated, @RockRoller01 has mentioned bringing up some numbers of gameplay elements' dimensions across countless skins in a couple of days, which we can use to alter the current specifications we had set.

[Loreos7]

Release	Master

Skins: BTMC Freedom Dive, Bacon boi 1.0 blue

[peppy]

Of note, this needs to be resolved before the next release. Increasing by the amount required to support the skin above would be a good start if we don't hear back from rockroller or find the time to investigate further ourselves.

[RockRoller01]

I've gone and grabbed stats for all the files that @bdach listed on discord. For animated files I checked for their base version and the first frame, checking all frames didnt really feel worth it. Overall this goes over ~4200 skins.

https://gist.github.com/RockRoller01/0a25249c86fda4c5a0c3d8fb97c28041

If stats for any other files are needed just let me know, now that I have working code it takes no time to get them.

[Loreos7]

I can still see the small difference. There are harsh shadows appear near a note.

Release	Master with #24975

[peppy]

I can still see the small difference. There are harsh shadows appear near a note.

If you're talking about master after #24975, then this is to be expected. Further changes still need to be applied in order to fix this issue, which is why it's still open.