Adjust osu!mania "major" barlines to be less visually distracting #24930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies to both "triangles" and "argon" skins.
In most cases. Closes ppy#15184.
peppy
force-pushed
the
adjust-mania-barlines
branch
from
0eac725 to
9949480
Compare
bdach
approved these changes
Sep 26, 2023
|
As I mentioned in the issue, the "flickering" was the barlines appearing at the bottom of the stage for a split second, which is likely some transform going wrong. That being said, barlines have been made pooled since that issue was made, so it may not be relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was waiting for a design for this but never came, and the existing design is very ugly and will probably stop people from using the new skins, so let's make a temporary change.
Applies to both "triangles" and "argon" skins.