Fix imported osu!stable scores being scaled by the classic scoring mode #23817
Conversation
osu.Game/Database/RealmAccess.cs
Outdated
| if (replayFilename == null) | ||
| continue; | ||
|
|
||
| using (var stream = files.Store.GetStream(replayFilename)) |
There was a problem hiding this comment.
I think that this should probably be under the try-catch too, to catch cases like possible missing files.
There was a problem hiding this comment.
Have expanded the scope slightly. Apart from that, I think this is okay to go with. As I mentioned on discord, I don't think it's going to be a huge issue that this takes some time to run. It should be in the realm of seconds, and the startup time is already pretty long so I think users will be willing to wait.
There was a problem hiding this comment.
Shouldn't that return the null stream? If not this function isn't properly documented.
There was a problem hiding this comment.
Not sure what kind of documentation you're expecting, but the underlying NativeStorage doesn't do much apart from pass through stream functions from .NET, so best to play it safe:
There was a problem hiding this comment.
It needs to document that it both may return null if the path doesn't exist (also needs to be nullable annotated but that's a given), which is the case that @bdach was mentioning, and also use <exception> tags to describe that it also throws via the native calls.
There was a problem hiding this comment.
Okay well I may have used a bad example. Non-existent files may not be an issue with this method but after seeing the number of dumb errors on sentry that are related to people's weird and corrupt storages I just feel like it's way safer to guard everything defensively.
Temporary fix for #23782 / #23756, preventing stable scores going into the billions when using the classic scoring mode.
It does NOT fix old lazer scores (which likely won't/can't be fixed), and does NOT convert SV1 to SV2 yet.