Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scores imported from stable use ScoreV1 value despite standardised scoring enabled #23756

Closed
bdach opened this issue Jun 5, 2023 · 2 comments · Fixed by #24072
Closed

Scores imported from stable use ScoreV1 value despite standardised scoring enabled #23756

bdach opened this issue Jun 5, 2023 · 2 comments · Fixed by #24072
Assignees
Labels
area:scoring priority:0 Showstopper. Critical to the next release.

Comments

@bdach
Copy link
Collaborator

bdach commented Jun 5, 2023

Type

Game behaviour

Bug description

  1. Import a stable score
  2. Go to leaderboard of the map the stable score was set on
  3. The beatmap leaderboard will use the raw ScoreV1 value from the replay, rather than a recomputed ScoreV2 analogue, causing the leaderboard to contain fundamentally incomparable stable scores (uncapped) and lazer-only scores (capped to 1M).

Regressed due to https://github.com/ppy/osu/pull/23638/files#diff-f83261c3fa399856c647f34ec303775b78826663ff84e05910ed4cfaf63ef9a9L77-R78.

Fixing would require a method of converting ScoreV1 score values to ScoreV2 standardised values, somehow.

Screenshots or videos

standardised scoring classic scoring
2023.513.0 osu_2023-06-05_20-43-13 osu_2023-06-05_20-43-19
2023.605.0 osu_2023-06-05_20-44-43 osu_2023-06-05_20-44-52

Version

2023.605.0 / current master

Logs

-

@peppy
Copy link
Member

peppy commented Jun 12, 2023

Should this be resolved via #23817? It says "temporary" but I'm not sure on what the future holds here – @smoogipoo are you still working on a better conversion algorithm that is going to arrive soon? If so can this issue be assigned to you?

@smoogipoo
Copy link
Contributor

Yes I'm still working on converting scores. This PR isn't resolved, the mentioned PR was a temporary fix to prevent scores in the billions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scoring priority:0 Showstopper. Critical to the next release.
Projects
Status: Done
3 participants