Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subheadings to maintenance section in settings #18802

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Added subheadings to maintenance section in settings #18802

merged 7 commits into from
Jun 22, 2022

Conversation

Supersonicboss1
Copy link
Contributor

At the moment, the maintenance section is just one big block of buttons, seemingly ordered in no meaningful way.
This PR separates each 'category' into its own subheading to improve the general feel of that section, even though it's not generally used.

osu_2022-06-21_23-48-08

@smoogipoo
Copy link
Contributor

I'm not sure what you've done to the files in this branch, but it broke people's gits. Fixed in 0d9a313, and also applied some changes since no new files should be created with #nullable disable.

smoogipoo
smoogipoo previously approved these changes Jun 22, 2022
@smoogipoo smoogipoo requested a review from peppy June 22, 2022 04:16
@peppy
Copy link
Member

peppy commented Jun 22, 2022

There's a lot more that needs to be done to make these settings actually parseable, and I'm not sure how much this helps but I guess it's one step forward.

For my own sanity I've force pushed to remove the broken commit. Nothing else has been changed.

@peppy peppy enabled auto-merge June 22, 2022 04:47
@peppy peppy merged commit 92e5560 into ppy:master Jun 22, 2022
@Supersonicboss1 Supersonicboss1 deleted the reorganised-maintenance-section branch June 22, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants