Classic scoring can reach negative values due to int overflow

[WitherFlower]

Type

Game behaviour

Bug description

Example map : https://osu.ppy.sh/beatmapsets/1427667#osu/2939553

This happens on any map with more than sqrt(2^31-1) objects (~46k), and is due to int overflow in the objectCount * objectCount multiplication in the following code :

osu/osu.Game/Scoring/Legacy/ScoreInfoExtensions.cs

Line 53 in 52dc02f

return (long)Math.Round((objectCount * objectCount * 32.57 + 100000) * standardisedTotalScore / ScoreProcessor.MAX_SCORE);

One would hope changing objectCount to a long should resolve the issue, as the overflow limit would now be sqrt(2^63-1) hitobjects, or a little bit above 3 billion...

Screenshots or videos

Version

2023.1114.1-lazer

Logs

logs.zip