Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindings 2 (no merging needed) #116

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Update bindings 2 (no merging needed) #116

merged 2 commits into from
Aug 7, 2024

Conversation

hwsmm
Copy link
Collaborator

@hwsmm hwsmm commented Aug 5, 2024

I'll keep this open to reduce duplicate effort on updating bindings.

Reviews are welcomed, but I don't think we need to update bindings every time SDL changes their API, so you don't need to merge this now. I'm doing this because I usually keep -git packages up to date.

Feel free to take over maintaining if I look inactive here!

Relevant osu!framework branch

My osu!framework SDL3 Audio also follows this PR, so expect build failures there without this.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Gonna get this in to support ppy/osu-framework#5790

@smoogipoo smoogipoo merged commit 2ec3cb8 into ppy:master Aug 7, 2024
1 check passed
@hwsmm hwsmm mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants