Update bindings (no merging needed) #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking into initial SDL3 support for Ryujinx and we need |
|
New package available as https://www.nuget.org/packages/ppy.SDL3-CS/2024.731.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll keep this open to reduce duplicate effort on updating bindings.
Reviews are welcomed, but I don't think we need to update bindings every time SDL changes their API, so you don't need to merge this now. I'm doing this because I usually keep
-gitpackages up to date.updating SDL3 broke osu! againFeel free to take over maintaining if I look inactive here!
Relevant osu!framework branch
My ppy/osu-framework#6002 (SDL3 Audio) also follows this PR, so expect build failures there without this.
Some notable changes:
Due to Updated more functions to use SDL_GetStringRule libsdl-org/SDL#10311,reverted from SDL.SDLArray.CreatePooled(a new method) is used to prevent usingSDL_Freeon disposal.