Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/LinkedIn #11

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Feature/LinkedIn #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0c0e768
Package
borut-t Sep 4, 2023
384c3bb
API
borut-t Sep 4, 2023
ccc3d51
WebView
borut-t Sep 4, 2023
08888a7
Authenticator
borut-t Sep 4, 2023
90f7ce8
Updates
borut-t Sep 4, 2023
c5814c8
Docs
borut-t Sep 4, 2023
fc352c1
Addressed PR comment.
borut-t Sep 19, 2023
2242cf7
Addressed PR comment.
borut-t Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addressed PR comment.
  • Loading branch information
@borut-t
borut-t committed Sep 19, 2023
commit fc352c1c865fa96330f6005d9b48c1e5628d35d9
2 changes: 1 addition & 1 deletion Sources/LinkedIn/LinkedInAuthenticator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ extension LinkedInAuthenticator: Authenticator {

storage.set(true, forKey: storageIsAuthenticatedKey)

let name = [profileResponse.localizedFirstName, profileResponse.localizedLastName].joined(separator: " ")
let name = "\(profileResponse.localizedFirstName) \(profileResponse.localizedLastName)"
return Response(
userId: profileResponse.id,
token: authResponse.accessToken,
Expand Down
59 changes: 32 additions & 27 deletions Sources/LinkedIn/WebView/LinkedInSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,40 @@
//
// File.swift
//
//
//
// Created by Borut Tomazin on 04/09/2023.
//

import SwiftUI

//struct LinkedInSheet: ViewModifier {
// typealias SuccessHandler = (Bool) -> Void
// typealias ErrorHandler = (Error) -> Void
// let isPresented: Binding<Bool>
// let onSuccess: SuccessHandler?
// let onError: ErrorHandler?
//
// func body(content: Content) -> some View {
// content
// .sheet(isPresented: isPresented) {
// LinkedInWebView { data in
// // Task { await viewModel.signInWithLinkedIn() }
// } onFailure: {
// // viewModel.error = .general
// }
// }
// }
//}
//
//extension View {
// func linkedInSheet(isPresented: Binding<Bool>,
// onSuccess: LinkedInSheet.SuccessHandler? = nil,
// onError: LinkedInSheet.ErrorHandler? = nil) -> some View {
// modifier(LinkedInSheet(isPresented: isPresented, onSuccess: onSuccess, onError: onError))
// }
//}
@available(iOS 15.0, *)
struct LinkedInSheet: ViewModifier {
typealias SuccessHandler = LinkedInWebView.SuccessHandler // (Bool) -> Void
typealias ErrorHandler = LinkedInWebView.ErrorHandler // (Error) -> Void
let config: LinkedInAuthenticator.Configuration
let isPresented: Binding<Bool>
let onSuccess: SuccessHandler?
let onError: ErrorHandler?

func body(content: Content) -> some View {
content
.sheet(isPresented: isPresented) {
LinkedInWebView(with: config) { data in
onSuccess?(data)
} onFailure: {
onError?()
}
}
}
}

@available(iOS 15.0, *)
extension View {
/// ViewModifier to present `LinkedInWebView` in sheet
func linkedInSheet(with config: LinkedInAuthenticator.Configuration,
isPresented: Binding<Bool>,
onSuccess: LinkedInSheet.SuccessHandler? = nil,
onError: LinkedInSheet.ErrorHandler? = nil) -> some View {
modifier(LinkedInSheet(config: config, isPresented: isPresented, onSuccess: onSuccess, onError: onError))
}
}