fix: unlisten channel names with period #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my, thanks a lot, silly that wasn't handled with the previous PR! |
|
Can you make all tests run again by replacing |
sk-shishi
force-pushed
the
fix/unlisten-period
branch
from
9fe33c9 to
44090f6
Compare
My bad, I forgot to revert it while I was trying to run the tests 😄 P/S: I force-pushed the commit. |
sk-shishi
force-pushed
the
fix/unlisten-period
branch
from
44090f6 to
eef4ef9
Compare
|
Awesome 😊 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to a12108a