fix: unlisten channel names with period

Similar to a12108a
porsager · Feb 2, 2023 · eef4ef9 · eef4ef9
1 parent 6778dc9
commit eef4ef9
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 6 deletions.
diff --git a/cjs/src/index.js b/cjs/src/index.js
@@ -192,7 +192,9 @@ function Postgres(a, b) {
         return
 
       delete channels[name]
-      return sql`unlisten ${ sql(name) }`
+      return sql`unlisten ${
+        sql.unsafe('"' + name.replace(/"/g, '""') + '"')
+      }`
     }
   }
 

diff --git a/cjs/tests/index.js b/cjs/tests/index.js
@@ -785,8 +785,10 @@ t('listen and notify with weird name', async() => {
   const sql = postgres(options)
   const channel = 'wat-;.ø.§'
   const result = await new Promise(async r => {
-    await sql.listen(channel, r)
+    const { unlisten } = await sql.listen(channel, r)
     sql.notify(channel, 'works')
+    await delay(50)
+    await unlisten()
   })
 
   return [

diff --git a/deno/src/index.js b/deno/src/index.js
@@ -193,7 +193,9 @@ function Postgres(a, b) {
         return
 
       delete channels[name]
-      return sql`unlisten ${ sql(name) }`
+      return sql`unlisten ${
+        sql.unsafe('"' + name.replace(/"/g, '""') + '"')
+      }`
     }
   }
 

diff --git a/deno/tests/index.js b/deno/tests/index.js
@@ -787,8 +787,10 @@ t('listen and notify with weird name', async() => {
   const sql = postgres(options)
   const channel = 'wat-;.ø.§'
   const result = await new Promise(async r => {
-    await sql.listen(channel, r)
+    const { unlisten } = await sql.listen(channel, r)
     sql.notify(channel, 'works')
+    await delay(50)
+    await unlisten()
   })
 
   return [

diff --git a/src/index.js b/src/index.js
@@ -192,7 +192,9 @@ function Postgres(a, b) {
         return
 
       delete channels[name]
-      return sql`unlisten ${ sql(name) }`
+      return sql`unlisten ${
+        sql.unsafe('"' + name.replace(/"/g, '""') + '"')
+      }`
     }
   }
 

diff --git a/tests/index.js b/tests/index.js
@@ -785,8 +785,10 @@ t('listen and notify with weird name', async() => {
   const sql = postgres(options)
   const channel = 'wat-;.ø.§'
   const result = await new Promise(async r => {
-    await sql.listen(channel, r)
+    const { unlisten } = await sql.listen(channel, r)
     sql.notify(channel, 'works')
+    await delay(50)
+    await unlisten()
   })
 
   return [