Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well known required #456

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Well known required #456

merged 4 commits into from
Dec 14, 2023

Conversation

bitfl0wer
Copy link
Member

@bitfl0wer bitfl0wer commented Dec 14, 2023

Title: Add User Authentication Feature

Description:

This pull request introduces user authentication functionality to our web application. The main goal of this feature is to ensure that each action performed on the platform is tied to a valid, logged-in user, thus providing accountability and maintaining data security.

Changes:

New models: Added the User model to represent users in our system. This model includes fields: username, password_hash, email etc.

User seriliazer and views: Implemented serializers and API views for user registration, login, and logout.

Authentication Middlewares: Added middlewares to check for a valid session or token before allowing access to certain views.

Tests: Included comprehensive test coverage for the new feature. Tests were implemented to verify user registration, login, and logout functionality, as well as checking authentication enforcement on applicable views.

Documentation: Updated API documentation related to User endpoints.

This feature is expected to improve the overall security of our application by properly managing user sessions and actions.

Note: You will see references to some helper tools like make_password and check_password methods, these are security measures to ensure we are not storing plain text passwords in the database.

This PR follows our Python coding standards and is fully linted and tested.

Requesting review and feedback. If all points are clear and no issues are detected during the review, we would appreciate it if this PR could be merged at the earliest convenience.

Related Issue: #123

@bitfl0wer bitfl0wer merged commit 7a517b3 into main Dec 14, 2023
5 checks passed
@bitfl0wer bitfl0wer deleted the well-known-required branch December 14, 2023 23:22
kozabrada123 added a commit that referenced this pull request Jan 31, 2024
kozabrada123 added a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant