Refactor/reuse reqwest client #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks good^^ Of course there are still a lot (41) of other calls to |
Do they, though? These Client::new() calls are just to make a The connection pool of the one client which executes the Requests can still be held this way, I'd assume. |
Merged
bitfl0wer
added a commit
that referenced
this pull request
Dec 14, 2023
Title: Add User Authentication Feature
Description:
This pull request introduces user authentication functionality to our
web application. The main goal of this feature is to ensure that each
action performed on the platform is tied to a valid, logged-in user,
thus providing accountability and maintaining data security.
Changes:
New models: Added the User model to represent users in our system. This
model includes fields: username, password_hash, email etc.
User seriliazer and views: Implemented serializers and API views for
user registration, login, and logout.
Authentication Middlewares: Added middlewares to check for a valid
session or token before allowing access to certain views.
Tests: Included comprehensive test coverage for the new feature. Tests
were implemented to verify user registration, login, and logout
functionality, as well as checking authentication enforcement on
applicable views.
Documentation: Updated API documentation related to User endpoints.
This feature is expected to improve the overall security of our
application by properly managing user sessions and actions.
Note: You will see references to some helper tools like make_password
and check_password methods, these are security measures to ensure we are
not storing plain text passwords in the database.
This PR follows our Python coding standards and is fully linted and
tested.
Requesting review and feedback. If all points are clear and no issues
are detected during the review, we would appreciate it if this PR could
be merged at the earliest convenience.
Related Issue: #123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the issue described in #120.