Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed validation result type from std::unordered_map to std::map #180

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

gbenziv
Copy link
Contributor

@gbenziv gbenziv commented Dec 31, 2020

Closes #179

  • Changed type
  • Changed map insert to merge

Pull Request Checklist

  • I have ensured that my commit message contains the Issue ID.
  • I have ensured that my commit message contains the feature/bugfix description.
  • I have updated the documentation accordingly.
  • I have ensured my code follows the coding guidelines.
  • I have ran lint in my code locally prior to submission.
  • I have built my changes in local successfully.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes #179

- Changed type
- Changed map insert to merge
@gbenziv gbenziv added the High Priority Needs urgent attention label Dec 31, 2020
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #180 (5ab08c4) into master (a933054) will decrease coverage by 4.99%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   94.61%   89.61%   -5.00%     
==========================================
  Files          37       43       +6     
  Lines         724      780      +56     
==========================================
+ Hits          685      699      +14     
- Misses         39       81      +42     
Impacted Files Coverage Δ
core/entity/customer.hpp 0.00% <0.00%> (ø)
core/entity/employee.hpp 100.00% <ø> (ø)
core/validator/validator.hpp 100.00% <ø> (ø)
...ore/domain/customermgmt/customermgmtcontroller.cpp 8.57% <8.57%> (ø)
...nittest/mock/customermgmt/customermgmtdatamock.hpp 33.33% <33.33%> (ø)
...nittest/mock/customermgmt/customermgmtviewmock.hpp 40.00% <40.00%> (ø)
...ore/domain/customermgmt/customermgmtcontroller.hpp 100.00% <100.00%> (ø)
core/domain/employeemgmt/employeecontroller.cpp 96.36% <100.00%> (ø)
core/domain/inventory/inventorycontroller.cpp 95.71% <100.00%> (ø)
core/domain/unittest/test_customermgmt.cpp 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a8d61...22030e7. Read the comment docs.

@gbenziv gbenziv merged commit 2699ef1 into master Dec 31, 2020
@gbenziv gbenziv deleted the dev/179 branch December 31, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Needs urgent attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change validation result type from std::unordered_map to std::map
1 participant