Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change validation result type from std::unordered_map to std::map #179

Closed
gbenziv opened this issue Dec 31, 2020 · 1 comment · Fixed by #180
Closed

Change validation result type from std::unordered_map to std::map #179

gbenziv opened this issue Dec 31, 2020 · 1 comment · Fixed by #180
Assignees
@gbenziv
Labels
High Priority Needs urgent attention

Comments

@gbenziv
Copy link
Contributor

gbenziv commented Dec 31, 2020

No description provided.

@gbenziv gbenziv added the High Priority Needs urgent attention label Dec 31, 2020
@gbenziv gbenziv self-assigned this Dec 31, 2020
@gbenziv
Copy link
Contributor Author

gbenziv commented Dec 31, 2020

Change from:

 validationResult->insert(validator.result().begin(), validator.result().end());

to

validationResult->merge(validator.result());

gbenziv added a commit that referenced this issue Dec 31, 2020
@gbenziv
Changed validation result type from std::unordered_map to std::map
22030e7 
Closes #179

- Changed type
- Changed map insert to merge
@gbenziv gbenziv mentioned this issue Dec 31, 2020
Merged
8 tasks
gbenziv added a commit that referenced this issue Dec 31, 2020
@gbenziv
Changed validation result type from std::unordered_map to std::map (#180
2699ef1 
)

Closes #179

- Changed type
- Changed map insert to merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbenziv gbenziv

Labels
High Priority Needs urgent attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed validation result type from std::unordered_map to std::map pointonsoftware/pscore
1 participant
@gbenziv