Skip to content

IWidgetLink improvements #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

GuidoZam
Copy link
Contributor

@GuidoZam GuidoZam commented May 1, 2024

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]

What's in this Pull Request?

Added new properties to the IWidgetLink interface to allow more customization options.
The new properties are:

  • title: to enable the change of the default text of the link.
  • color: custom color, if not specified the "brand" one will be used.
  • target: specify an alternative target property for the generated anchor tag, the default remains _blank.

Copy link
Collaborator

@michaelmaillot michaelmaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GuidoZam,

Thanks a lot for this enhancement suggestion!

I've made some changes request, let me know if something is not clear 🙂

@GuidoZam
Copy link
Contributor Author

Hi @michaelmaillot, I've made some updates to reflect your change requests. However I cannot reproduce the TS compiling error that you have, it just compiles without any problem.

@michaelmaillot michaelmaillot merged commit 759d11b into pnp:dev Aug 16, 2024
1 check passed
@michaelmaillot
Copy link
Collaborator

Merged manually, thank you!

@michaelmaillot michaelmaillot added this to the 3.20.0 milestone Aug 16, 2024
@GuidoZam GuidoZam deleted the dashboard-link-improvements branch August 17, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants