DynamicForm - Custom sorting #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmaillot
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Thanks for this PR @srpmtt!
I've added a few suggestions, let me know if you have any questions.
| const { customFormatting, hiddenByFormula, infoErrorMessages, isSaving } = this.state; | ||
|
|
||
| if (this.props.fieldOrder) { | ||
| fieldCollection = this.sortFields(fieldCollection, this.props.fieldOrder) |
There was a problem hiding this comment.
Is there a reason to sort fields during rendering instead of doing it during mouting / fieldOrder prop update?
From my perspective, this could be done in the getListInformation method, triggered in mount / update event, to avoid unnecessary re-ordering and which is already doing all the work around list / list item / fields.
| let {fieldCollection} = this.state | ||
| const { customFormatting, hiddenByFormula, infoErrorMessages, isSaving } = this.state; | ||
|
|
||
| if (this.props.fieldOrder) { |
There was a problem hiding this comment.
It would be better to check the length of the array (as it could be empty if controlled outside for example) to avoid unnecessary Map set.
michaelmaillot
approved these changes
Aug 16, 2024
|
Merged manually, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicForm custom sorting.
Added a new optional prop fieldOrder (string[]), the values are the fields internal names.