maint: fix and cleanup maint/extracterrmsgs #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch3/most
|
|
test:mpich/custom |
|
test:mpich/ch3/most nearly all ✔️ , just 1 unreleated io failure on ch3-tcp-centos32 |
|
test:mpich/ch3/most |
4 tasks
raffenet
approved these changes
Feb 7, 2022
maint/extracterrmsgs
Outdated
| $generic_loc{"UNKNOWN"} = ":[NONE]"; | ||
| $longnames{"UNKNOWN"} = "Unknown error class"; | ||
| # add a dummy UNKNOWN entry in the front. | ||
| # NOTE: assume all other generic message are loower cases so "UNKNOWN" will |
We have been manually setting MPI error class index in src/mpi/errhan/baseerrnames.txt, and it has been out-of-sync with the values defined in mpi.h. This commit does following: * Remove the index from baseerrnames.txt and directly load the defined value from mpi.h instead. * Add UNKNOWN entry to map the missing entries in baseerrnames.txt. * When autogen.sh fails to extract error messages, do not generate dummy defmsg.h, fail instead. The dummy header will break the error class message translation anyway.
Add some indentation to the generated src/mpi/errhan/defmsg.h.
Re-initializing %KnownErrRoutines for every line of the source code is waste of time. Just load once can make the script run much faster -- from 3 seconds to a fraction of a second.
Use strict prevents misuse of global variables in Perl scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
We have been manually setting MPI error class index in
src/mpi/errhan/baseerrnames.txt, and it has been out-of-sync with the
values defined in mpi.h. This commit does the following:
value from mpi.h instead.
UNKNOWNentry to map the missing entries in baseerrnames.txt.defmsg.h, fail instead. The dummy header will break the error class
message translation anyway.
defmsg.hTODO
use strictto the scriptAuthor Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.