spawn: better error handling when connection time out #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2201_trecv_cancel
branch
5 times, most recently
from
933ae45 to
9809762
Compare
|
test:mpich/ch3/tcp |
hzhou
force-pushed
the
2201_trecv_cancel
branch
from
9809762 to
262f2a9
Compare
|
test:mpich/ch3/tcp |
hzhou
force-pushed
the
2201_trecv_cancel
branch
from
262f2a9 to
a658bdb
Compare
|
test:mpich/warnings/auto |
raffenet
reviewed
Feb 4, 2022
hzhou
force-pushed
the
2201_trecv_cancel
branch
from
a658bdb to
4054b46
Compare
|
Rebased. One commit ( |
We give user an option to set timeout in MPI_Comm_connect and MPI_Comm_accept. User will need check the error return when time out occurs. Create MPIX_ERR_TIMEOUT for this purpose.
When user set timeout for MPI_Comm_connect and MPI_Comm_accept, we need cancel the pending operations and return proper error code so user can check and handle appropriately.
When MPI_Comm_connect timeout, by convention we return error class MPI_ERR_PORT.
The code to check valid error class was imprecise. Add macros is_valid_err_class and clean it up.
|
test:mpich/ch3/most |
raffenet
approved these changes
Jul 15, 2022
I've seen that failure in unrelated PRs before, but it seems more frequent here, let me re-run the test to confirm. |
|
test:mpich/ch3/most All clean ✔️ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When user set timeout for MPI_Comm_connect and MPI_Comm_accept, we need
cancel the pending operations and return the proper error code so user can
check and handle appropriately.
Depends on #5819
Fixes #5815
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.