Implement enchanting system

src/block/Block.php

@@ -36,6 +36,7 @@
 use pocketmine\data\runtime\RuntimeDataWriter;
 use pocketmine\entity\Entity;
 use pocketmine\entity\projectile\Projectile;
+use pocketmine\item\enchantment\ItemEnchantmentFlags;
 use pocketmine\item\enchantment\VanillaEnchantments;
 use pocketmine\item\Item;
 use pocketmine\item\ItemBlock;
@@ -67,6 +68,7 @@ class Block{
 	protected BlockIdentifier $idInfo;
 	protected string $fallbackName;
 	protected BlockTypeInfo $typeInfo;
+	protected int $itemEnchantmentFlag;
 	protected Position $position;
 
 	/** @var AxisAlignedBB[]|null */
@@ -80,10 +82,11 @@ class Block{
 	/**
 	 * @param string $name English name of the block type (TODO: implement translations)
 	 */
-	public function __construct(BlockIdentifier $idInfo, string $name, BlockTypeInfo $typeInfo){
+	public function __construct(BlockIdentifier $idInfo, string $name, BlockTypeInfo $typeInfo, int $itemEnchantmentFlag = ItemEnchantmentFlags::NONE){
 		$this->idInfo = $idInfo;
 		$this->fallbackName = $name;
 		$this->typeInfo = $typeInfo;
+		$this->itemEnchantmentFlag = $itemEnchantmentFlag;
 		$this->position = new Position(0, 0, 0, null);
 
 		$calculator = new RuntimeDataSizeCalculator();

src/block/EnchantingTable.php

@@ -48,7 +48,7 @@ public function onInteract(Item $item, int $face, Vector3 $clickVector, ?Player
 		if($player instanceof Player){
 			//TODO lock
 
-			$player->setCurrentWindow(new EnchantInventory($this->position));
+			$player->setCurrentWindow(new EnchantInventory($this->position, $player));
 		}
 
 		return true;

src/block/VanillaBlocks.php

@@ -59,6 +59,7 @@
 use pocketmine\block\utils\WoodType;
 use pocketmine\crafting\FurnaceType;
 use pocketmine\entity\projectile\Projectile;
+use pocketmine\item\enchantment\ItemEnchantmentFlags;
 use pocketmine\item\Item;
 use pocketmine\item\ToolTier;
 use pocketmine\math\Facing;
@@ -964,7 +965,7 @@ public function getBreakTime(Item $item) : float{
 
 		$pumpkinBreakInfo = new Info(BreakInfo::axe(1.0));
 		self::register("pumpkin", new Pumpkin(new BID(Ids::PUMPKIN), "Pumpkin", $pumpkinBreakInfo));
-		self::register("carved_pumpkin", new CarvedPumpkin(new BID(Ids::CARVED_PUMPKIN), "Carved Pumpkin", $pumpkinBreakInfo));
+		self::register("carved_pumpkin", new CarvedPumpkin(new BID(Ids::CARVED_PUMPKIN), "Carved Pumpkin", $pumpkinBreakInfo, ItemEnchantmentFlags::HEAD));
 		self::register("lit_pumpkin", new LitPumpkin(new BID(Ids::LIT_PUMPKIN), "Jack o'Lantern", $pumpkinBreakInfo));
 
 		self::register("pumpkin_stem", new PumpkinStem(new BID(Ids::PUMPKIN_STEM), "Pumpkin Stem", new Info(BreakInfo::instant())));

src/block/inventory/EnchantInventory.php

@@ -23,8 +23,18 @@
 
 namespace pocketmine\block\inventory;
 
+use pocketmine\data\bedrock\EnchantmentIdMap;
 use pocketmine\inventory\SimpleInventory;
 use pocketmine\inventory\TemporaryInventory;
+use pocketmine\item\enchantment\EnchantmentHelper as Helper;
+use pocketmine\item\enchantment\EnchantmentInstance;
+use pocketmine\item\Item;
+use pocketmine\item\ItemTypeIds;
+use pocketmine\item\VanillaItems;
+use pocketmine\network\mcpe\protocol\PlayerEnchantOptionsPacket;
+use pocketmine\network\mcpe\protocol\types\Enchant;
+use pocketmine\network\mcpe\protocol\types\EnchantOption;
+use pocketmine\player\Player;
 use pocketmine\world\Position;
 
 class EnchantInventory extends SimpleInventory implements BlockInventory, TemporaryInventory{
@@ -33,8 +43,71 @@ class EnchantInventory extends SimpleInventory implements BlockInventory, Tempor
 	public const SLOT_INPUT = 0;
 	public const SLOT_LAPIS = 1;
 
-	public function __construct(Position $holder){
+	private Player $player;
+
+	/** @var EnchantOption[] $options */
+	private array $options = [];
+	private array $outputs = [];
+
+	public function __construct(Position $holder, Player $player){
 		$this->holder = $holder;
+		$this->player = $player;
 		parent::__construct(2);
 	}
+
+	protected function onSlotChange(int $index, Item $before) : void{
+		if($index == self::SLOT_INPUT){
+			$this->options = Helper::getEnchantOptions($this->holder, $this->getItem(self::SLOT_INPUT), $this->player->getXpSeed());
+			$this->outputs = [];
+
+			if(!empty($this->options)){
+				$this->player->getNetworkSession()->sendDataPacket(PlayerEnchantOptionsPacket::create($this->options));
+			}
+		}
+
+		parent::onSlotChange($index, $before);
+	}
+
+	public function getInput() : ?Item{
+		return $this->getItem(self::SLOT_INPUT);
+	}
+
+	public function getLapis() : ?Item{
+		return $this->getItem(self::SLOT_LAPIS);
+	}
+
+	public function getOutput(int $optionId) : Item{
+		$this->prepareOutput($optionId);
+		return $this->outputs[$optionId];
+	}
+
+	private function prepareOutput(int $optionId) : void{
+		if(isset($this->outputs[$optionId])){
+			return;
+		}
+
+		$option = $this->options[$optionId] ?? null;
+		if(is_null($option)){
+			throw new \RuntimeException("Failed to find enchantment option with network id $optionId");
+		}
+
+		$enchantments = array_map(
+			fn(Enchant $e) => new EnchantmentInstance(EnchantmentIdMap::getInstance()->fromId($e->getId()), $e->getLevel()),
+			array_merge(
+				$option->getEquipActivatedEnchantments(),
+				$option->getHeldActivatedEnchantments(),
+				$option->getSelfActivatedEnchantments()
+			)
+		);
+
+		$outputItem = $this->getItem(self::SLOT_INPUT);
+		if($outputItem->getTypeId() === ItemTypeIds::BOOK){
+			$outputItem = VanillaItems::ENCHANTED_BOOK();
+		}
+		foreach($enchantments as $enchantment){
+			$outputItem->addEnchantment($enchantment);
+		}
+
+		$this->outputs[$optionId] = $outputItem;
+	}
 }

src/data/bedrock/item/ItemSerializerDeserializerRegistrar.php

@@ -223,6 +223,7 @@ private function register1to1ItemMappings() : void{
 		$this->map1to1Item(Ids::ECHO_SHARD, Items::ECHO_SHARD());
 		$this->map1to1Item(Ids::EGG, Items::EGG());
 		$this->map1to1Item(Ids::EMERALD, Items::EMERALD());
+		$this->map1to1Item(Ids::ENCHANTED_BOOK, Items::ENCHANTED_BOOK());
 		$this->map1to1Item(Ids::ENCHANTED_GOLDEN_APPLE, Items::ENCHANTED_GOLDEN_APPLE());
 		$this->map1to1Item(Ids::ENDER_PEARL, Items::ENDER_PEARL());
 		$this->map1to1Item(Ids::EXPERIENCE_BOTTLE, Items::EXPERIENCE_BOTTLE());

src/entity/Human.php

@@ -211,6 +211,14 @@ public function getXpManager() : ExperienceManager{
 		return $this->xpManager;
 	}
 
+	public function getXpSeed() : int{
+		return $this->xpSeed;
+	}
+
+	protected function setRandomXpSeed() : void{
+		$this->xpSeed = random_int(Limits::INT32_MIN, Limits::INT32_MAX);
+	}
+
 	public function getXpDropAmount() : int{
 		//this causes some XP to be lost on death when above level 1 (by design), dropping at most enough points for
 		//about 7.5 levels of XP.
@@ -334,7 +342,7 @@ function(Inventory $unused, array $oldItems) use ($syncHeldItem) : void{
 		if(($xpSeedTag = $nbt->getTag(self::TAG_XP_SEED)) instanceof IntTag){
 			$this->xpSeed = $xpSeedTag->getValue();
 		}else{
-			$this->xpSeed = random_int(Limits::INT32_MIN, Limits::INT32_MAX);
+			$this->setRandomXpSeed();
 		}
 	}
 

src/inventory/transaction/EnchantTransaction.php

@@ -0,0 +1,88 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+ */
+
+declare(strict_types=1);
+
+namespace pocketmine\inventory\transaction;
+
+use pocketmine\block\inventory\EnchantInventory;
+use pocketmine\inventory\transaction\action\InventoryAction;
+use pocketmine\item\Item;
+use pocketmine\item\ItemTypeIds;
+use pocketmine\player\Player;
+
+class EnchantTransaction extends InventoryTransaction{
+
+	private int $optionId;
+	private ?Item $inputItem = null;
+	private int $lapisCost = 0;
+
+	public function __construct(Player $source, int $optionId){
+		$this->optionId = $optionId;
+		parent::__construct($source);
+	}
+
+	public function validate() : void{
+		if(count($this->actions) < 1){
+			throw new TransactionValidationException("Transaction must have at least one action to be executable");
+		}
+
+		/** @var EnchantInventory $enchantWindow */
+		$enchantWindow = $this->source->getCurrentWindow();
+		if(!$this->inputItem->equalsExact($enchantWindow->getInput())){
+			throw new TransactionValidationException("Incorrect input item");
+		}
+
+		if(!$this->source->isCreative()){
+			$enchantLevel = $this->getEnchantLevel();
+			if($this->lapisCost !== $enchantLevel){
+				throw new TransactionValidationException("Expected the amount of lapis lazuli spent to be {$this->getEnchantLevel()}, but received $this->lapisCost");
+			}
+
+			$xpLevel = $this->source->getXpManager()->getXpLevel();
+			if($xpLevel < $enchantLevel){
+				throw new TransactionValidationException("Expected player to have xp level at least of $enchantLevel, but received $xpLevel");
+			}
+		}
+	}
+
+	public function addAction(InventoryAction $action) : void{
+		parent::addAction($action);
+
+		$sourceItem = $action->getSourceItem();
+		$targetItem = $action->getTargetItem();
+
+		if($sourceItem->getTypeId() === ItemTypeIds::LAPIS_LAZULI){
+			$this->lapisCost = $sourceItem->getCount() - $targetItem->getCount();
+		}else{
+			$this->inputItem = $sourceItem;
+		}
+	}
+
+	public function execute() : void{
+		parent::execute();
+		$this->source->onEnchant($this->getEnchantLevel());
+	}
+
+	public function getEnchantLevel() : int{
+		return $this->optionId + 1;
+	}
+}

src/item/Armor.php

@@ -26,6 +26,7 @@
 use pocketmine\color\Color;
 use pocketmine\event\entity\EntityDamageEvent;
 use pocketmine\inventory\ArmorInventory;
+use pocketmine\item\enchantment\ItemEnchantmentFlags;
 use pocketmine\item\enchantment\ProtectionEnchantment;
 use pocketmine\item\enchantment\VanillaEnchantments;
 use pocketmine\math\Vector3;
@@ -44,8 +45,8 @@ class Armor extends Durable{
 
 	protected ?Color $customColor = null;
 
-	public function __construct(ItemIdentifier $identifier, string $name, ArmorTypeInfo $info){
-		parent::__construct($identifier, $name);
+	public function __construct(ItemIdentifier $identifier, string $name, ArmorTypeInfo $info, int $enchantmentFlag = ItemEnchantmentFlags::NONE){
+		parent::__construct($identifier, $name, $enchantmentFlag);
 		$this->armorInfo = $info;
 	}
 

src/item/EnchantedBook.php

@@ -0,0 +1,30 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+ */
+
+declare(strict_types=1);
+
+namespace pocketmine\item;
+
+class EnchantedBook extends Item{
+	public function getMaxStackSize() : int{
+		return 1;
+	}
+}

src/item/Item.php

@@ -38,6 +38,7 @@
 use pocketmine\entity\Entity;
 use pocketmine\entity\Living;
 use pocketmine\item\enchantment\EnchantmentInstance;
+use pocketmine\item\enchantment\ItemEnchantmentFlags;
 use pocketmine\math\Vector3;
 use pocketmine\nbt\LittleEndianNbtSerializer;
 use pocketmine\nbt\NBT;
@@ -110,7 +111,8 @@ class Item implements \JsonSerializable{
 	 */
 	public function __construct(
 		private ItemIdentifier $identifier,
-		protected string $name = "Unknown"
+		protected string $name = "Unknown",
+		private int $enchantmentFlag = ItemEnchantmentFlags::NONE
 	){
 		$this->nbt = new CompoundTag();
 	}
@@ -455,6 +457,10 @@ public function getVanillaName() : string{
 		return $this->name;
 	}
 
+	public function getEnchantmentFlag() : int{
+		return $this->enchantmentFlag;
+	}
+
 	final public function canBePlaced() : bool{
 		return $this->getBlock()->canBePlaced();
 	}

src/item/ItemBlock.php

@@ -25,6 +25,7 @@
 
 use pocketmine\block\Block;
 use pocketmine\data\runtime\RuntimeDataDescriber;
+use pocketmine\item\enchantment\ItemEnchantmentFlags;
 
 /**
  * Class used for Items that directly represent blocks, such as stone, dirt, wood etc.
@@ -34,9 +35,10 @@
  */
 final class ItemBlock extends Item{
 	public function __construct(
-		private Block $block
+		private Block $block,
+		int $enchantmentFlag = ItemEnchantmentFlags::NONE
 	){
-		parent::__construct(ItemIdentifier::fromBlock($block), $block->getName());
+		parent::__construct(ItemIdentifier::fromBlock($block), $block->getName(), $enchantmentFlag);
 	}
 
 	protected function describeState(RuntimeDataDescriber $w) : void{

src/item/ItemTypeIds.php

@@ -303,8 +303,9 @@ private function __construct(){
 	public const MANGROVE_BOAT = 20264;
 	public const GLOW_BERRIES = 20265;
 	public const CHERRY_SIGN = 20266;
+	public const ENCHANTED_BOOK = 20267;
 
-	public const FIRST_UNUSED_ITEM_ID = 20267;
+	public const FIRST_UNUSED_ITEM_ID = 20268;
 
 	private static int $nextDynamicId = self::FIRST_UNUSED_ITEM_ID;
 

src/item/StringToItemParser.php

@@ -1276,6 +1276,7 @@ private static function registerItems(self $result) : void{
 		$result->register("egg", fn() => Items::EGG());
 		$result->register("elixir", fn() => Items::MEDICINE()->setType(MedicineType::ELIXIR()));
 		$result->register("emerald", fn() => Items::EMERALD());
+		$result->register("enchanted_book", fn() => Items::ENCHANTED_BOOK());
 		$result->register("enchanted_golden_apple", fn() => Items::ENCHANTED_GOLDEN_APPLE());
 		$result->register("enchanting_bottle", fn() => Items::EXPERIENCE_BOTTLE());
 		$result->register("ender_pearl", fn() => Items::ENDER_PEARL());