-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement enchanting system #5953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/item/enchantment/VanillaEnchantments.php # src/network/mcpe/handler/ItemStackRequestExecutor.php
IvanCraft623
requested changes
Jul 31, 2023
IvanCraft623
previously requested changes
Jul 31, 2023
diamond-gold
reviewed
Aug 1, 2023
dktapps
requested changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only reviewed this at the surface level so far.
ipad54
reviewed
Aug 1, 2023
ShockedPlot7560
requested changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only had a quick read. The logic seems OK, to be seen more precisely.
…kTypeInfo::getEnchantmentTags`
dktapps
reviewed
Aug 15, 2023
in the future we'll be able to get rid of InventoryTransaction->getSource()
dktapps
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Gameplay
Related to Minecraft gameplay experience
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This adds the long-awaited functionality of enchanting items via an enchanting table.
Changes
API changes
getEnchantmentSeed()
,setEnchantmentSeed(int)
,generateEnchantmentSeed()
getPrimaryItemFlags
,getSecondaryItemFlags
,hasPrimaryItemType
,hasSecondaryItemType
in Enchantment are now deprecatedgetEnchantmentTags()
,getEnchantability()
getEnchantmentTags()
(some block items, such as carved pumpkin and mob heads, can be enchanted (with enchanted books in the anvil when the appropriate functionality is added))getEnchantmentTags()
getInput()
,getLapis()
,getOutput(int)
,getOption(int)
isCompatibleWith(Enchantment)
,getMinEnchantingPower(int)
,getMaxEnchantingPower(int)
enchantability
for each armor material)getMaterial()
getMaterial()
getEnchantability()
syncEnchantingTableOptions
,getEnchantingTableOptionIndex
Behavioural changes
Add enchanting functionality for an enchanting table.
Follow-up
equipSound
,toughness
,isDyeable
.Tests
Untitled.1.mp4