Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depend on plotly.js-dist instead of plotly.js #205

Closed
wants to merge 1 commit into from
Closed

depend on plotly.js-dist instead of plotly.js #205

wants to merge 1 commit into from

Conversation

archmoj
Copy link

@archmoj archmoj commented Oct 1, 2020

Wondering if this is the right fix in respect to plotly/plotly.js#5182 (comment)?

@dmt0 @nicolaskruchten

@archmoj archmoj added the bug label Oct 1, 2020
@archmoj
Copy link
Author

archmoj commented Oct 2, 2020

We could/should possibly hold on this possible "breaking change".
The issue is addressed by plotly/plotly.js#5189 at plotly.js as well as color* dependencies for now.
However considering switching to plotly.js-dist might be an option later on the road.
cc: @alexcjohnson

@archmoj archmoj mentioned this pull request Oct 20, 2020
Closed
@archmoj archmoj mentioned this pull request Sep 7, 2021
Open
@archmoj archmoj closed this Sep 7, 2021
@archmoj archmoj deleted the use-plotly.js-dist branch September 7, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@archmoj