Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect plotly.js imports to dist builds #5221

Closed
wants to merge 1 commit into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 19, 2020

Follow up of #5189 and as suggested by @dy in #5182 (comment).
Changes required to be able to bump & import plotly.js in chart-studio.
Otherwise we have to downgrade color* modules to versions used before #5172.
Potential impacts:

  • faster and more stable imports/exports in production
  • may need some adjustments to keep development process smooth

@dmt0
@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Oct 19, 2020
@archmoj
Copy link
Contributor Author

archmoj commented Oct 19, 2020

Potential impacts:

  • may need some adjustments to keep development process smooth

test_dashboard updates & works just fine. So there might be no problem there.

@archmoj
Copy link
Contributor Author

archmoj commented Oct 20, 2020

With this there is now only one test failing on streambed:
https://app.circleci.com/pipelines/github/plotly/streambed/4860/workflows/1a742eea-581a-4e11-9af3-1d569bbf0dae/jobs/59005/parallel-runs/5?filterBy=FAILED

Plus, it might be best to have this change in a minor release.
Therefore in order to fix this in a patch release, I will open a new PR to downgrade color* modules just for now.

@nicolaskruchten
Copy link
Contributor

Don't we already have dist bundles specifically for this?

@archmoj
Copy link
Contributor Author

archmoj commented Oct 20, 2020

Don't we already have dist bundles specifically for this?

We do have. But major changes required in other packages in order to point to it e.g. plotly/react-plotly.js#205

@archmoj archmoj added type: maintenance and removed bug something broken regression this used to work labels Oct 20, 2020
@archmoj archmoj added this to the v1.58.0 milestone Oct 20, 2020
@archmoj archmoj closed this Oct 22, 2020
@archmoj archmoj deleted the redirect-imports-to-dist-builds branch October 22, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants