Disable plotly server URL by default #4690
Conversation
src/plot_api/plot_config.js
Outdated
| 'and the showLink/sendData on-graph link' | ||
| 'When set it determines base URL for', | ||
| 'the \'Edit in Chart Studio\' (aka sendDataToCloud) mode bar button', | ||
| 'and the showLink/sendData on-graph link.' |
There was a problem hiding this comment.
Can we at least include the url for CSC in the description? I guess that should be https://chart-studio.plotly.com? Something like "To enable sending your data to Plotly's public cloud, you need to set both plotlyServerURL to 'https://chart-studio.plotly.com' and showSendToCloud to true"
There was a problem hiding this comment.
Good call. Done in 7d5492d using https://plotly.com
There was a problem hiding this comment.
Extra info added in 9959cb8.
There was a problem hiding this comment.
Thanks - I'd take https://plotly.com out, since I believe that's not going to work, and just include https://chart-studio.plotly.com
There was a problem hiding this comment.
Let's not use https://plotly.com as this will confuse people, let's only use https://chart-studio.plotly.com as the example.
Let's also not call it "Plotly's public cloud" but rather "Chart Studio Cloud" please.
Finally, let's replace sendDataToCloud (which is not one of the options!) with showEditInChartStudio/showSendToCloud which are slight variants on each other...
There was a problem hiding this comment.
Revised in d81e598.
Yes please. |
Resolves #4689
This PR changes the default value for
config.plotlyServerURLoption to empty string in 514aef4.Please also note that empty string would be ignored in
Plotly.sendDataToCloudin f661184,Therefore in order to
Edit in Chart Studio(usingmodebarbuttonseditInChartStudioorsendDataToCloud) theconfig.plotlyServerURLis required.@plotly/plotly_js