early return from sendDataToCloud when using blank plotlyServerURL de…

…fault
plotly · Mar 26, 2020 · f661184 · f661184
1 parent 514aef4
commit f661184
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/plot_api/plot_config.js b/src/plot_api/plot_config.js
@@ -34,8 +34,9 @@ var configAttributes = {
         valType: 'string',
         dflt: '',
         description: [
-            'Sets base URL for the \'Edit in Chart Studio\' (aka sendDataToCloud) mode bar button',
-            'and the showLink/sendData on-graph link'
+            'When set it determines base URL for',
+            'the \'Edit in Chart Studio\' (aka sendDataToCloud) mode bar button',
+            'and the showLink/sendData on-graph link.'
         ].join(' ')
     },
 

diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -215,9 +215,10 @@ function positionPlayWithData(gd, container) {
 }
 
 plots.sendDataToCloud = function(gd) {
-    gd.emit('plotly_beforeexport');
-
     var baseUrl = (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL;
+    if(!baseUrl) return;
+
+    gd.emit('plotly_beforeexport');
 
     var hiddenformDiv = d3.select(gd)
         .append('div')

diff --git a/test/jasmine/tests/config_test.js b/test/jasmine/tests/config_test.js
@@ -509,8 +509,7 @@ describe('config argument', function() {
                 expect(gd._context.plotlyServerURL).toBe('');
 
                 Plotly.Plots.sendDataToCloud(gd);
-                expect(form.action.substring(0, 17)).toBe('http://localhost:');
-                expect(form.method).toBe('post');
+                expect(form).toBe(undefined);
             })
             .catch(failTest)
             .then(done);