Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and test annotations with mathjax #1788

Merged
merged 6 commits into from
Jun 14, 2017
Merged

Conversation

alexcjohnson
Copy link
Collaborator

fixes #1787 - the bug came in when we simplified the class structure of annotation elements.
@etpinard another quick fix - lets hope the test image works consistently on CI. If it does, I'll probably add some more mathjax image tests (for elements other than annotations) when I tweak drawing.bBox for #1782

@etpinard
Copy link
Contributor

image

Hmm. Looks like CI doesn't like MathJax intermittently.

@etpinard etpinard added status: reviewable bug something broken labels Jun 14, 2017
@etpinard etpinard added this to the 1.28.0 milestone Jun 14, 2017
@alexcjohnson
Copy link
Collaborator Author

Hmm. Looks like CI doesn't like MathJax intermittently.

Annoying. I guess this is probably the same sporadic delay we saw in https://github.com/plotly/streambed/issues/9508

I guess what I'll do is take MathJax out of the annotations mock, and make one MathJax mock that we skip in CI for now but tries to cover everywhere we support MathJax at present.

@etpinard
Copy link
Contributor

I guess what I'll do is take MathJax out of the annotations mock, and make one MathJax mock that we skip in CI for now but tries to cover everywhere we support MathJax at present.

Very good idea, until we have more time to investigate plotly/streambed#9508

To do so, just add one expression to this filter function.

@alexcjohnson
Copy link
Collaborator Author

Actually I made a mistake in 033bee3 - fixed in b0d1af2 - that means it's likely MathJax will work fine on CI after all. But I found a bunch of other issues when developing a more complete MathJax test mock so I'm going to defer that to a separate PR if you don't mind.

@etpinard
Copy link
Contributor

etpinard commented Jun 14, 2017

so I'm going to defer that to a separate PR if you don't mind.

Sounds good 👍

@etpinard
Copy link
Contributor

💃 💃 💃

@alexcjohnson alexcjohnson merged commit b6843a6 into master Jun 14, 2017
@alexcjohnson alexcjohnson deleted the annotations-mathjax branch June 14, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

annotations with mathjax are misaligned
2 participants