-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix and test annotations with mathjax #1788
Conversation
Annoying. I guess this is probably the same sporadic delay we saw in https://github.com/plotly/streambed/issues/9508 I guess what I'll do is take MathJax out of the annotations mock, and make one MathJax mock that we skip in CI for now but tries to cover everywhere we support MathJax at present. |
Very good idea, until we have more time to investigate plotly/streambed#9508 To do so, just add one expression to this filter function. |
Sounds good 👍 |
💃 💃 💃 |
fixes #1787 - the bug came in when we simplified the class structure of annotation elements.
@etpinard another quick fix - lets hope the test image works consistently on CI. If it does, I'll probably add some more mathjax image tests (for elements other than annotations) when I tweak
drawing.bBox
for #1782