Implement RocksDBStore #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
reviewed
Feb 7, 2020
limebell
requested changes
Feb 11, 2020
earlbread
force-pushed
the
rocks-db
branch
2 times, most recently
from
6677e32 to
9f49cee
Compare
longfin
previously approved these changes
Feb 11, 2020
limebell
previously approved these changes
Feb 12, 2020
moreal
suggested changes
Feb 12, 2020
moreal
previously approved these changes
Feb 12, 2020
limebell
previously approved these changes
Feb 12, 2020
longfin
approved these changes
Feb 12, 2020
moreal
approved these changes
Feb 12, 2020
limebell
approved these changes
Feb 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
+ Coverage 86.65% 86.69% +0.04%
==========================================
Files 227 227
Lines 19654 19654
==========================================
+ Hits 17031 17039 +8
+ Misses 1414 1405 -9
- Partials 1209 1210 +1
|
dahlia
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements RocksDBStore and closes #211. Currently, only the parts stored in the file have been changed to use RocksDB(Please see
IterateTransactionIds,GetTransaction,PutTransaction,DeleteTransaction,ContainsTransaction,IterateBlockHashes,GetBlockDigest,PutBlock,DeleteBlock,ContainsBlock,GetBlockStates, andSetBlockStatesmethods). Other methods are just the same asDefaultStore. And alsoRocksDBStoreTestis skipped in environments where RocksDB is not available for test compatibility.