Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RocksDB implementation of IStore #211

Closed
dahlia opened this issue Apr 19, 2019 · 2 comments · Fixed by #789
Closed

RocksDB implementation of IStore #211

dahlia opened this issue Apr 19, 2019 · 2 comments · Fixed by #789
Assignees
@earlbread
Labels
storage Related to storage (Libplanet.Store) suggestion Suggestion or feature request

Comments

@dahlia
Copy link
Contributor

dahlia commented Apr 19, 2019

Currently there is only one implementation of IStore: FileStore. Although this is highly portable, there are many limitations too. To leverage advanced features of RocksDB, I suggest to add a new implementation of IStore that uses RocksDB under the hood.
@dahlia dahlia added the suggestion Suggestion or feature request label Apr 19, 2019
@stale
Copy link

stale bot commented Oct 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Oct 30, 2019
@stale stale bot closed this as completed Nov 6, 2019
@limebell limebell reopened this Nov 7, 2019
@stale stale bot removed the stale The issue is stale label Nov 7, 2019
@stale
Copy link

stale bot commented Jan 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Jan 6, 2020
@earlbread earlbread mentioned this issue Feb 7, 2020
Merged
@stale stale bot removed the stale The issue is stale label Feb 7, 2020
@dahlia dahlia added the storage Related to storage (Libplanet.Store) label Feb 7, 2020
limebell pushed a commit to limebell/libplanet that referenced this issue Jul 7, 2021
@boscohyun
Merge pull request planetarium#211 from boscohyun/bug-fix/arena-battle
8a6a327 
Remove hard coding in `WeeklyArenaState`
OnedgeLee pushed a commit to OnedgeLee/libplanet that referenced this issue Jan 31, 2023
@Atralupus
Merge pull request planetarium#211 from Atralupus/fix/rstrip-bug
1ded14d 
fix: Replace rstrip -> removesuffix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@earlbread earlbread

Labels
storage Related to storage (Libplanet.Store) suggestion Suggestion or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement RocksDBStore earlbread/libplanet
3 participants
@dahlia @limebell @earlbread