Sanity check in PrivateKey constructor using bytes #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
reviewed
Aug 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 87.94% 87.92% -0.03%
==========================================
Files 198 198
Lines 14426 14439 +13
==========================================
+ Hits 12687 12695 +8
- Misses 1425 1429 +4
- Partials 314 315 +1
|
Co-Authored-By: Seunghun Lee <[email protected]>
dahlia
suggested changes
Aug 15, 2019
CHANGES.md
Outdated
| @@ -82,6 +82,7 @@ To be released. | |||
| the `Transaction<T>` more than once. [[#413]] | |||
| - `BlockChain<T>.Swap()` became to omit common block finding when `render` is | |||
| `false`. [[#423]] | |||
| - `PrivateKey(bytes)` became to valid check. [[#438]] | |||
There was a problem hiding this comment.
Suggested change
| - `PrivateKey(bytes)` became to valid check. [[#438]] | |
| - `PrivateKey(byte[])` constructor became to check validity. [[#438]] |
Libplanet/Crypto/PrivateKey.cs
Outdated
| } | ||
| catch (ArgumentException) | ||
| { | ||
| throw new InvalidOperationException( |
There was a problem hiding this comment.
I believe ArgumentException would be more suitable here.
Suggested change
| throw new InvalidOperationException( | |
| throw new ArgumentException( |
dahlia
previously approved these changes
Aug 15, 2019
earlbread
previously approved these changes
Aug 15, 2019
longfin
requested changes
Aug 15, 2019
Libplanet/Crypto/PrivateKey.cs
Outdated
| ); | ||
|
|
||
| var key = new PrivateKey(param); | ||
| var publicKey = key.PublicKey; |
There was a problem hiding this comment.
This statement also seems unnatural, so it would be better if there is some comment about it.
Libplanet/Crypto/PrivateKey.cs
Outdated
| ); | ||
|
|
||
| var key = new PrivateKey(param); | ||
| var publicKey = key.PublicKey; |
There was a problem hiding this comment.
Suggested change
| var publicKey = key.PublicKey; | |
| var _ = key.PublicKey; |
longfin
approved these changes
Aug 15, 2019
earlbread
approved these changes
Aug 15, 2019
dahlia
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #358