Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity check on new PrivateKey() #358

Closed
longfin opened this issue Jul 17, 2019 · 1 comment · Fixed by #438
Closed

Sanity check on new PrivateKey() #358

longfin opened this issue Jul 17, 2019 · 1 comment · Fixed by #438
Assignees
@ipdae
Labels
good first issue Good for newcomers

Comments

@longfin
Copy link
Member

longfin commented Jul 17, 2019

Currently, there is no validation of privateKey parameter on Libplanet.Crypto.PrivateKey's constructor. so illegal bytes can be passed to new PrivateKey() and occurs error when being used. it would be good if we catch this error in the constructor.
@longfin longfin added the good first issue Good for newcomers label Jul 17, 2019
@ipdae
Copy link
Member

ipdae commented Aug 15, 2019

i'll try this issue.

@ipdae ipdae mentioned this issue Aug 15, 2019
Merged
limebell pushed a commit to limebell/libplanet that referenced this issue Jul 7, 2021
Merge pull request planetarium#358 from planetarium/feature/20210402-…
169ff3b 
…bump-submodule

Bump submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipdae ipdae

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanity check in PrivateKey constructor using bytes ipdae/libplanet
2 participants
@longfin @ipdae