Make LiteDBStore & FileStore to atomically store transactions #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
force-pushed
the
atomic-storic-txs
branch
from
2b2a84c to
3c491cb
Compare
longfin
previously approved these changes
Aug 7, 2019
earlbread
previously approved these changes
Aug 7, 2019
dahlia
force-pushed
the
atomic-storic-txs
branch
2 times, most recently
from
0049b5d to
b7fa968
Compare
earlbread
reviewed
Aug 8, 2019
| var random = new System.Random(); | ||
| var md5 = MD5.Create(); | ||
| Transaction<AtomicityTestAction> tx; | ||
| for (int j = 0; j < 50; j++) |
There was a problem hiding this comment.
Shouldn't this be txCount too?
There was a problem hiding this comment.
Not necessarily; it's arbitrary.
dahlia
force-pushed
the
atomic-storic-txs
branch
from
b7fa968 to
d6b028c
Compare
earlbread
previously approved these changes
Aug 8, 2019
dahlia
force-pushed
the
atomic-storic-txs
branch
from
d6b028c to
d195181
Compare
longfin
previously approved these changes
Aug 9, 2019
earlbread
previously approved these changes
Aug 9, 2019
dahlia
force-pushed
the
atomic-storic-txs
branch
from
d195181 to
19c6132
Compare
earlbread
approved these changes
Aug 9, 2019
|
@earlbread @longfin Sorry, I rebased it on the current master again. |
longfin
approved these changes
Aug 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
+ Coverage 88.11% 88.16% +0.05%
==========================================
Files 198 198
Lines 14067 14226 +159
==========================================
+ Hits 12395 12543 +148
- Misses 1361 1371 +10
- Partials 311 312 +1
|
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
…w-state Improve HackAndSlash, RankingBattle execution time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is an alternative solution to the same problem that #411 aims to address.