Sharing a chain between swarms can lead deadlocks

planetarium · Aug 8, 2019 · b7fa968 · b7fa968
1 parent e1a8eb8
commit b7fa968
Showing 1 changed file with 10 additions and 17 deletions.
diff --git a/Libplanet.Tests/Net/SwarmTest.cs b/Libplanet.Tests/Net/SwarmTest.cs
@@ -233,22 +233,20 @@ CancellationToken cancellationToken
         }
 
         [Fact(Timeout = Timeout)]
-        public async Task CanExchangePeer()
+        public async Task ExchangePeer()
         {
-            BlockChain<DumbAction> chain = _blockchains[0];
-
             var a = new Swarm<DumbAction>(
-                chain,
+                _blockchains[0],
                 new PrivateKey(),
                 1,
                 host: IPAddress.Loopback.ToString());
             var b = new Swarm<DumbAction>(
-                chain,
+                _blockchains[1],
                 new PrivateKey(),
                 1,
                 host: IPAddress.Loopback.ToString());
             var c = new Swarm<DumbAction>(
-                chain,
+                _blockchains[2],
                 new PrivateKey(),
                 1,
                 host: IPAddress.Loopback.ToString());
@@ -317,26 +315,24 @@ public async Task CanExchangePeer()
         [Fact(Timeout = Timeout)]
         public async Task DetectAppProtocolVersion()
         {
-            BlockChain<DumbAction> chain = _blockchains[0];
-
             var a = new Swarm<DumbAction>(
-                chain,
+                _blockchains[0],
                 new PrivateKey(),
                 host: IPAddress.Loopback.ToString(),
                 appProtocolVersion: 2);
             var b = new Swarm<DumbAction>(
-                chain,
+                _blockchains[1],
                 new PrivateKey(),
                 host: IPAddress.Loopback.ToString(),
                 appProtocolVersion: 3);
 
             var c = new Swarm<DumbAction>(
-                chain,
+                _blockchains[2],
                 new PrivateKey(),
                 host: IPAddress.Loopback.ToString(),
                 appProtocolVersion: 2);
             var d = new Swarm<DumbAction>(
-                chain,
+                new BlockChain<DumbAction>(_blockchains[0].Policy, new FileStoreFixture().Store),
                 new PrivateKey(),
                 host: IPAddress.Loopback.ToString(),
                 appProtocolVersion: 3);
@@ -378,16 +374,14 @@ void GameHandler(object sender, DifferentProtocolVersionEventArgs e)
                 isCalled = true;
             }
 
-            BlockChain<DumbAction> chain = _blockchains[0];
-
             var a = new Swarm<DumbAction>(
-                chain,
+                _blockchains[0],
                 new PrivateKey(),
                 host: IPAddress.Loopback.ToString(),
                 appProtocolVersion: 2,
                 differentVersionPeerEncountered: GameHandler);
             var b = new Swarm<DumbAction>(
-                chain,
+                _blockchains[1],
                 new PrivateKey(),
                 host: IPAddress.Loopback.ToString(),
                 appProtocolVersion: 3);
@@ -555,7 +549,6 @@ public async Task GetTx()
             Swarm<DumbAction> swarmA = _swarms[0];
             Swarm<DumbAction> swarmB = _swarms[1];
 
-            BlockChain<DumbAction> chainA = _blockchains[0];
             BlockChain<DumbAction> chainB = _blockchains[1];
 
             Transaction<DumbAction> tx = Transaction<DumbAction>.Create(