Improve branch point finding #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/improve-next-hashes
branch
from
f79adb0 to
1c9dec1
Compare
longfin
changed the title
BlockChain<T>.FindNextHashes()
longfin
changed the title
BlockChain<T>.FindNextHashes()
longfin
force-pushed
the
feature/improve-next-hashes
branch
2 times, most recently
from
6578780 to
1daa479
Compare
earlbread
reviewed
Jun 10, 2019
earlbread
previously approved these changes
Jun 10, 2019
longfin
force-pushed
the
feature/improve-next-hashes
branch
from
e53654f to
2ccd1e5
Compare
|
The rebase failed: To rebase manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase feature/improve-next-hashes
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash master
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase |
longfin
force-pushed
the
feature/improve-next-hashes
branch
from
2ccd1e5 to
a5e4368
Compare
earlbread
previously approved these changes
Jun 10, 2019
dahlia
reviewed
Jun 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 87% 87.06% +0.05%
==========================================
Files 180 180
Lines 11555 11532 -23
==========================================
- Hits 10054 10040 -14
+ Misses 1258 1253 -5
+ Partials 243 239 -4
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 87% 87.06% +0.05%
==========================================
Files 180 180
Lines 11555 11532 -23
==========================================
- Hits 10054 10040 -14
+ Misses 1258 1253 -5
+ Partials 243 239 -4
|
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 87% 80.96% -6.05%
==========================================
Files 180 61 -119
Lines 11555 1434 -10121
==========================================
- Hits 10054 1161 -8893
+ Misses 1258 245 -1013
+ Partials 243 28 -215 |
Co-Authored-By: Hong Minhee <[email protected]> (+2 squashed commit) Co-Authored-By: Seunghun Lee <[email protected]>
longfin
force-pushed
the
feature/improve-next-hashes
branch
from
1a4bae8 to
62cb3c3
Compare
dahlia
approved these changes
Jun 11, 2019
earlbread
approved these changes
Jun 11, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
bump libplanet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance of
BlockChain<T>.Blocks.Contains(),BlockChain<T>.FindBranchPoint()andBlockChain<T>.FindNextHashes()to reduce response time for block hashes query.