Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory consumption within BlockChain<T>.FindBranchPoint #282

Closed
longfin opened this issue Jun 13, 2019 · 0 comments · Fixed by #299
Closed

Reduce memory consumption within BlockChain<T>.FindBranchPoint #282

longfin opened this issue Jun 13, 2019 · 0 comments · Fixed by #299
Labels
help wanted Extra attention is needed

Comments

@longfin
Copy link
Member

longfin commented Jun 13, 2019 •
edited
Loading

The latest implementation of BlockChain<T>.FindBranchPoint is to use memory very heavily by loading all the block hashes in the chain into memory and calling ImmutableHashSet.Contains().

I think we can probably reduce this memory consumption because we only need to know that block hashes belonging to BlockLocator are in the current chain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement BlockChain<T>.FindBranchPoint again, to reduce memory consumption moreal/libplanet
1 participant
@longfin