Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extended find_closest_word unittest to cover both similarity metrics #219

Merged
merged 1 commit into from
Jan 9, 2025
Merged

extended find_closest_word unittest to cover both similarity metrics #219

merged 1 commit into from
Jan 9, 2025

Conversation

BeneHTWG
Copy link
Contributor

@BeneHTWG BeneHTWG commented Jan 9, 2025

pkeilbach
pkeilbach approved these changes Jan 9, 2025
View reviewed changes
Copy link
Owner

@pkeilbach pkeilbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkeilbach pkeilbach added the assignments Assignment submissions or anything else related to the assignments label Jan 9, 2025
@pkeilbach pkeilbach added this to the Winter term 2024/25 milestone Jan 9, 2025
@pkeilbach pkeilbach merged commit cbfc6c3 into pkeilbach:main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkeilbach pkeilbach pkeilbach approved these changes

Assignees

@BeneHTWG BeneHTWG

Labels
assignments Assignment submissions or anything else related to the assignments
Projects
None yet
Milestone
Winter term 2024/25
Development

Successfully merging this pull request may close these issues.

missing test coverage in embeddings assignment
2 participants
@BeneHTWG @pkeilbach