Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing test coverage in embeddings assignment #214

Closed
BeneHTWG opened this issue Jan 3, 2025 · 1 comment · Fixed by #219
Closed

missing test coverage in embeddings assignment #214

BeneHTWG opened this issue Jan 3, 2025 · 1 comment · Fixed by #219
Assignees
@BeneHTWG
Labels
assignments Assignment submissions or anything else related to the assignments 🏅 🏅 2 bonus points
Milestone
Winter term 2024/25

Comments

@BeneHTWG
Copy link
Contributor

BeneHTWG commented Jan 3, 2025

  • the method find_closest_word is not tested with the cosine similarity regarding the correct word prediction
@pkeilbach pkeilbach added assignments Assignment submissions or anything else related to the assignments 🏅 🏅 2 bonus points labels Jan 7, 2025
@pkeilbach pkeilbach added this to the Winter term 2024/25 milestone Jan 7, 2025
@pkeilbach
Copy link
Owner

Nice, can you take that @BeneHTWG ?

@BeneHTWG BeneHTWG mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeneHTWG BeneHTWG

Labels
assignments Assignment submissions or anything else related to the assignments 🏅 🏅 2 bonus points
Projects
None yet
Milestone
Winter term 2024/25
Development

Successfully merging a pull request may close this issue.

extended find_closest_word unittest to cover both similarity metrics BeneHTWG/htwg-practical-nlp
2 participants
@pkeilbach @BeneHTWG