Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ublock origin twitch video swap not working anymore. #309

Closed
mmizab opened this issue Dec 10, 2024 · 18 comments
Closed

ublock origin twitch video swap not working anymore. #309

mmizab opened this issue Dec 10, 2024 · 18 comments

Comments

@mmizab
Copy link

mmizab commented Dec 10, 2024

you fuckedup the script I had to roll back to old version.

@mmizab mmizab changed the title twitch video swap not working anymore. ublock origin twitch video swap not working anymore. Dec 10, 2024
@andy1k
Copy link

andy1k commented Dec 10, 2024

Not working anymore

@zPhenomm
Copy link

zPhenomm commented Dec 10, 2024

Vaft doesn't work for me anymore, I'm getting prerolls. It worked a few hours ago, there might be a problem with the new commit.

@ZachPL
Copy link

ZachPL commented Dec 10, 2024

Yeah it's the new commit you can just change your resource location to the old commit and it will work again

https://raw.githubusercontent.com/pixeltris/TwitchAdSolutions/722f5b96241ef1d92998b87f941690e47e475379/video-swap-new/video-swap-new-ublock-origin.js

@pktpls
Copy link

pktpls commented Dec 10, 2024

Same for vaft/vaft-ublock-origin.js, going back to previous commit works. Not using any other tools, just UBO+this.

@pixeltris
Copy link
Owner

My bad, fixed in 4770850

@pktpls
Copy link

pktpls commented Dec 10, 2024

Hehe nice one - works here, thank you!

@tmud67
Copy link

tmud67 commented Dec 10, 2024

So how do I fix this now?

(still not working for me at 2:30 PST)

@webmastir
Copy link

@tmud67 restart your browser. It should pull the latest changes.

@tmud67
Copy link

tmud67 commented Dec 10, 2024

Hmm I turned on and off the blocker, reset the computer, still not working

@webmastir
Copy link

@tmud67 What URL do you have configured for userResourcesLocation in uBlock Origin > Advanced Settings?

@tmud67
Copy link

tmud67 commented Dec 10, 2024

It is working now just took a minute i guess

@omnosti
Copy link

omnosti commented Dec 11, 2024

I had to remove the master link from my filter lists, it suddenly started messing up the formatting on non-Twitch websites for me.

@pixeltris
Copy link
Owner

@omnosti I'm not sure how that would be possible. This is the first line of code:

if ( /(^|\.)twitch\.tv$/.test(document.location.hostname) === false ) { return; }

And the filter is twitch.tv##+js(twitch-videoad)

@SteezyGH
Copy link

Whenever I load any website with this list enabled in uBlock they are all in text mode, here's a screen cap of it on this very issue page, along with a capture of the uBlock Origin Asset Logger. The logger also throws up a bunch of invalid filter errors upon reloading when enabling the list. Not sure if you'd want this as a separate issue.

Screenshot (1666)

@pixeltris
Copy link
Owner

The url isn't a filterlist. Read the instructions in the readme on how to use url https://github.com/pixeltris/TwitchAdSolutions?tab=readme-ov-file#applying-a-script-ublock-origin

@AlexIs387
Copy link

The url isn't a filterlist. Read the instructions in the readme on how to use url https://github.com/pixeltris/TwitchAdSolutions?tab=readme-ov-file#applying-a-script-ublock-origin

I did it and ads didn't stop, even after restarting the browser, why don't you admit that this will not work and stop fooling?

@SteezyGH
Copy link

The url isn't a filterlist. Read the instructions in the readme on how to use url https://github.com/pixeltris/TwitchAdSolutions?tab=readme-ov-file#applying-a-script-ublock-origin

Whoops yeah that's what the problem was, everything works fine for me now sorry for the misunderstanding

@Xe11o
Copy link

Xe11o commented Dec 17, 2024

@tmud67 What URL do you have configured for userResourcesLocation in uBlock Origin > Advanced Settings?

It's not working for me currently. userResourcesLocation value is https://raw.githubusercontent.com/pixeltris/TwitchAdSolutions/722f5b96241ef1d92998b87f941690e47e475379/video-swap-new/video-swap-new-ublock-origin.js, have applied and restarted browser.

:EDIT:

Switched to using the 'userscript' version applied with Tampermonkey extension, seems to be working so guess this is my method for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests