Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load user groups #1176

Merged
merged 4 commits into from
Feb 24, 2023
Merged

feat: load user groups #1176

merged 4 commits into from
Feb 24, 2023

Conversation

jczhong84
Copy link
Collaborator

@jczhong84 jczhong84 commented Feb 23, 2023 •
edited
Loading

  • add the suppport of creating and updating user groups
  • add latest_partitions and earliest_partitions as metastore may provide it directly instead of all partitions.

@baumandm
Copy link
Contributor

Question, why is this tied to the metastore loader and not a new plugin type? We use Hive, and while we can implement the get_all_user_groups method and have it connect to Ldap, it doesn't seem like it really fits there. We also have multiple Hive metastores, but we would only want to schedule the user sync for one of them.

If you have a different metastore that provides user/groups information directly, I can see how this would make more sense.

@jczhong84
Copy link
Collaborator Author

makes sense, I'll remove the sync job and decouple it from metastore loader, but only keep the help functions in the PR

@jczhong84 jczhong84 changed the title feat: load and sync user groups from metastore feat: load user groups Feb 23, 2023
czgu
czgu reviewed Feb 23, 2023
View reviewed changes
@czgu czgu merged commit 0f6dc03 into pinterest:metadata Feb 24, 2023
czgu pushed a commit that referenced this pull request Feb 27, 2023
@jczhong84
feat: add more metadata support (#1182)
2bc6052 
* feat: add table custom properties (#1165)

* feat: add table custom properties

* comments

* update package version

* feat: load tag from metastore (#1164)

* feat: load tag from metastore

* comments

* comments

* feat: add column level tag support (#1169)

* feat: add column level tag support

* comments

* set commit False for create_table

* tagsDOM

* use verify_data_column_permission

* ffix linter

* feat: load data table ownership from metastore (#1170)

* load data table owners from metastore

* add tooltip

* fix linter

* comments

* fix circular import

* display name comments

* display name comments

* get owner types comments

* feat: load user groups  (#1176)

* feat: load and sync user groups from metastore

* remove sync group task

* remove and add delta

* refactor

* chore: merge alembic changes (#1180)

* chore: merge alembic changes

* add foregin key name
@jczhong84 jczhong84 deleted the feat/group branch April 7, 2023 00:41
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
@jczhong84 @rohan-sh1
feat: add more metadata support (pinterest#1182)
1626a28 
* feat: add table custom properties (pinterest#1165)

* feat: add table custom properties

* comments

* update package version

* feat: load tag from metastore (pinterest#1164)

* feat: load tag from metastore

* comments

* comments

* feat: add column level tag support (pinterest#1169)

* feat: add column level tag support

* comments

* set commit False for create_table

* tagsDOM

* use verify_data_column_permission

* ffix linter

* feat: load data table ownership from metastore (pinterest#1170)

* load data table owners from metastore

* add tooltip

* fix linter

* comments

* fix circular import

* display name comments

* display name comments

* get owner types comments

* feat: load user groups  (pinterest#1176)

* feat: load and sync user groups from metastore

* remove sync group task

* remove and add delta

* refactor

* chore: merge alembic changes (pinterest#1180)

* chore: merge alembic changes

* add foregin key name
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@jczhong84 @aidenprice
feat: add more metadata support (pinterest#1182)
e9db8f1 
* feat: add table custom properties (pinterest#1165)

* feat: add table custom properties

* comments

* update package version

* feat: load tag from metastore (pinterest#1164)

* feat: load tag from metastore

* comments

* comments

* feat: add column level tag support (pinterest#1169)

* feat: add column level tag support

* comments

* set commit False for create_table

* tagsDOM

* use verify_data_column_permission

* ffix linter

* feat: load data table ownership from metastore (pinterest#1170)

* load data table owners from metastore

* add tooltip

* fix linter

* comments

* fix circular import

* display name comments

* display name comments

* get owner types comments

* feat: load user groups  (pinterest#1176)

* feat: load and sync user groups from metastore

* remove sync group task

* remove and add delta

* refactor

* chore: merge alembic changes (pinterest#1180)

* chore: merge alembic changes

* add foregin key name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jczhong84 @baumandm @czgu