feat: add column level tag support #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Feb 16, 2023
czgu
reviewed
Feb 16, 2023
querybook/server/datasources/tag.py
Outdated
| methods=["GET"], | ||
| ) | ||
| def get_tags_by_column_id(column_id: int): | ||
| column = metastore_logic.get_column_by_id(column_id) |
There was a problem hiding this comment.
can you add verify_data_column_permission so the checks are in 1 place?
czgu
approved these changes
Feb 16, 2023
czgu
pushed a commit
that referenced
this pull request
Feb 27, 2023
* feat: add table custom properties (#1165) * feat: add table custom properties * comments * update package version * feat: load tag from metastore (#1164) * feat: load tag from metastore * comments * comments * feat: add column level tag support (#1169) * feat: add column level tag support * comments * set commit False for create_table * tagsDOM * use verify_data_column_permission * ffix linter * feat: load data table ownership from metastore (#1170) * load data table owners from metastore * add tooltip * fix linter * comments * fix circular import * display name comments * display name comments * get owner types comments * feat: load user groups (#1176) * feat: load and sync user groups from metastore * remove sync group task * remove and add delta * refactor * chore: merge alembic changes (#1180) * chore: merge alembic changes * add foregin key name
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: add table custom properties (pinterest#1165) * feat: add table custom properties * comments * update package version * feat: load tag from metastore (pinterest#1164) * feat: load tag from metastore * comments * comments * feat: add column level tag support (pinterest#1169) * feat: add column level tag support * comments * set commit False for create_table * tagsDOM * use verify_data_column_permission * ffix linter * feat: load data table ownership from metastore (pinterest#1170) * load data table owners from metastore * add tooltip * fix linter * comments * fix circular import * display name comments * display name comments * get owner types comments * feat: load user groups (pinterest#1176) * feat: load and sync user groups from metastore * remove sync group task * remove and add delta * refactor * chore: merge alembic changes (pinterest#1180) * chore: merge alembic changes * add foregin key name
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add table custom properties (pinterest#1165) * feat: add table custom properties * comments * update package version * feat: load tag from metastore (pinterest#1164) * feat: load tag from metastore * comments * comments * feat: add column level tag support (pinterest#1169) * feat: add column level tag support * comments * set commit False for create_table * tagsDOM * use verify_data_column_permission * ffix linter * feat: load data table ownership from metastore (pinterest#1170) * load data table owners from metastore * add tooltip * fix linter * comments * fix circular import * display name comments * display name comments * get owner types comments * feat: load user groups (pinterest#1176) * feat: load and sync user groups from metastore * remove sync group task * remove and add delta * refactor * chore: merge alembic changes (pinterest#1180) * chore: merge alembic changes * add foregin key name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add column level tag support. For now, it will only show the tags synced from metastore, but not allow users to add/edit a tag through UI