Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: fix validator deadlock and enhance retry (#9522) #9545

Merged
merged 3 commits into from
Aug 11, 2023
Merged

dm: fix validator deadlock and enhance retry (#9522) #9545

merged 3 commits into from
Aug 11, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9522

What problem does this PR solve?

Issue Number: close #9257

What is changed and how it works?

  • fix deadlock between error-process-routine and worker routine when err channel is full
  • remove object lock when fillResult
  • enhance retry by reusing the resumable errors in syncer

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

dm: fix validator deadlock and enhance retry

@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 11, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 11, 2023
Merged
1 task
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 11, 2023
@ti-chi-bot ti-chi-bot bot merged commit 337390b into pingcap:release-7.1 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees

@D3Hunter D3Hunter

Labels
approved area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-chi-bot @D3Hunter