dm: fix validator deadlock and enhance retry #9522
Conversation
ti-chi-bot
bot
added
needs-cherry-pick-release-6.5
ti-chi-bot
bot
added
the
size/L
|
/retest |
| @@ -199,7 +204,7 @@ type DataValidator struct { | |||
|
|
|||
| // fields in this field block are guarded by stateMutex | |||
There was a problem hiding this comment.
seems we can update the comment about which members this mutex guards
There was a problem hiding this comment.
which field do you mean? the range is not changed
| if err == context.Canceled { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
as its name, should we check it's a DB error? like a error instance from mysql.MySQLError
There was a problem hiding this comment.
no, as in comment says, it's a black list checking, we only filter known non-retriable errors.
this method is used to check whether db operation can retry, not just db error, network/conn error to
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #9257
What is changed and how it works?
fillResultCheck List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note