-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner(ticdc): Add backoff mechanism into changefeed restart logic (#4262) #4338
owner(ticdc): Add backoff mechanism into changefeed restart logic (#4262) #4338
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## release-5.2 #4338 +/- ##
================================================
Coverage ? 57.9329%
================================================
Files ? 194
Lines ? 19583
Branches ? 0
================================================
Hits ? 11345
Misses ? 7246
Partials ? 992 |
/merge |
@zhaoxinyu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c812709
|
/run-integration-test |
/run-unit-test |
/run-integration-test |
This is an automated cherry-pick of #4262
What problem does this PR solve?
Issue Number: close #3329 close #3987
What is changed and how it works?
Before this optimization:
When errors occurred in a changefeed, a simple backoff is leveraged to restart a changefeed:
If there are three errors which occurred in two minutes, the changefeed stays in "error" state and won't be restarted imediately.
After this optimization:
We utilize an exponential backoff mechanism in the changefeed restart logic. The mechanism is elaborated as follows:
InitialInterval
to aMaxInterval
. And if the duration since backoff start exceed theMaxElapsedTime
, the changefeed will be switched to "failed" state and will not be restarted until it is manually resumed.InitialInterval
.Check List
Tests
Release note