-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner(ticdc): Add backoff mechanism into changefeed restart logic #4262
owner(ticdc): Add backoff mechanism into changefeed restart logic #4262
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4262 +/- ##
================================================
+ Coverage 55.1722% 55.6826% +0.5104%
================================================
Files 485 495 +10
Lines 59829 60843 +1014
================================================
+ Hits 33009 33879 +870
- Misses 23484 23545 +61
- Partials 3336 3419 +83 |
/run-kafka-integration-test |
3 similar comments
/run-kafka-integration-test |
/run-kafka-integration-test |
/run-kafka-integration-test |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4335. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4336. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4337. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4338. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4339. |
In response to a cherrypick label: new pull request created: #4340. |
What problem does this PR solve?
Issue Number: close #3329 close #3987
What is changed and how it works?
Before this optimization:
When errors occurred in a changefeed, a simple backoff is leveraged to restart a changefeed:
If there are three errors which occurred in two minutes, the changefeed stays in "error" state and won't be restarted imediately.
After this optimization:
We utilize an exponential backoff mechanism in the changefeed restart logic. The mechanism is elaborated as follows:
InitialInterval
to aMaxInterval
. And if the duration since backoff start exceed theMaxElapsedTime
, the changefeed will be switched to "failed" state and will not be restarted until it is manually resumed.InitialInterval
.Check List
Tests
Release note