-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): DDL event support for the Debezium protocol #11674
Conversation
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, hongyunyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #11566
What is changed and how it works?
Debezium provides the SQL CREATE, ALTER, or DROP statement that results in the schema change. https://debezium.io/documentation/reference/2.7/connectors/mysql.html#mysql-schema-change-topic
This PR implements encoding for the DDL event and checkpoint event.
Difference between TiCDC and Debezium:
int
length is nil butint(11)
length is 11defaultValueExpression
may not same when the length of the default value is not equal to the column lengthCOLLATE
is "utf8_unicode_ci" andCHARACTER
is null, but TiCDC doesn'tCheck List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
yes
Release note