Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: update ticdc-debezium.md #19544

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

ticdc: update ticdc-debezium.md #19544

wants to merge 31 commits into from

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented Dec 2, 2024 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2024
@wk989898 wk989898 marked this pull request as draft December 2, 2024 04:29
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 6, 2024
@wk989898 wk989898 marked this pull request as ready for review December 9, 2024 07:19
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@lilin90 lilin90 added v9.0 translation/doing This PR's assignee is translating this PR. labels Jan 6, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 6, 2025
@lilin90 lilin90 self-assigned this Jan 6, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilin90
Copy link
Member

lilin90 commented Jan 6, 2025 •
edited
Loading

Note: Do not use hard Tabs in our documentation. Hard Tabs make the CI check fail. I've replaced each hard Tab with four spaces via the 852aa42 commit.

lilin90
lilin90 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 6, 2025
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 6, 2025
hfxsd
hfxsd reviewed Feb 7, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 7, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 7, 2025
View reviewed changes
hfxsd
hfxsd reviewed Feb 7, 2025
View reviewed changes
lilin90
lilin90 reviewed Feb 7, 2025
View reviewed changes
lilin90
lilin90 reviewed Feb 7, 2025
View reviewed changes
ticdc/ticdc-debezium.md Outdated

- Debezium converts `charsetName` to `"utf8mb4"` when the column collation is `"utf8_unicode_ci"` and the character set is null, but TiCDC does not.

- Debezium escapes ENUM elements, but TiCDC does not. For example, Debezium encodes ENUM elements ('c', 'd', 'g,''h') to ('c','d','g,\'\'h').
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example @wk989898. It does not display well.
image

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-06 03:13:18.443314318 +0000 UTC m=+327869.975726316: ☑️ agreed by lilin90.
  • 2025-02-07 05:50:54.711232319 +0000 UTC m=+423726.243644312: ☑️ agreed by hfxsd.

wk989898
wk989898 commented Feb 7, 2025
View reviewed changes
lilin90
lilin90 reviewed Feb 7, 2025
View reviewed changes
wk989898
wk989898 commented Feb 7, 2025
View reviewed changes
@lilin90
Copy link
Member

lilin90 commented Feb 8, 2025 •
edited
Loading

Note: Do not use hard Tabs in our documentation. Hard Tabs make the CI check fail. I've replaced each hard Tab with four spaces via the 852aa42 commit.

Content is ready except the note #19544 (comment).

wk989898
wk989898 commented Feb 28, 2025
View reviewed changes
ticdc/ticdc-debezium.md
| `payload.source.commit_ts` | Number | The `CommitTs` value of the event. |
| `payload.source.db` | String | The name of the database where the event occurs. |
| `payload.source.table` | String | The name of the table where the event occurs. |
| `schema.fields` | JSON | The type information of each field in the payload, including the schema information of the row data before and after the change. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `schema.fields` | JSON | The type information of each field in the payload, including the schema information of the row data before and after the change. |
| `schema.fields` | JSON | The type information of each field in the payload, including the schema information of the row data before and after the change. |
| `schema.fields[1].fields[n].tidb_type` | string | The tidb type of each column in the `payload.after`. it occurs when `enable-tidb-extension = true` |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@lilin90 lilin90

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wk989898 @lilin90 @hongyunyan @hfxsd