Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor: fix a bug that will cause processor Tick get stuck when downstream is Kafka (#11339) #11390

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11339

What problem does this PR solve?

Issue Number: close #11340

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Deploy a cdc cluster, create two changefeeds and synchronize the same table to both Kafka and TiDB separately.

Every 20 minutes, inject CDC to network isolation:

  • First, isolate cdc to Kafka network for 10 minutes.
  • Then, 20 minutes later, isolate cdc to downstream TiDB network for 10 minutes.

Repeat this process six times.

Before this PR, the lag in the MySQL sink changefeed was influenced by the Kafka sink changefeed when network isolation was introduced between CDC and Kafka:
nHHvw2tHOE

After this PR, only Kafka sink changefeed lag increasing during network isolation injection:
image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix a bug that causes the processor tick to get stuck when the downstream is Kafka and becomes unreachable.```

@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 4, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 26, 2024
Signed-off-by: dongmen <[email protected]>
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@4ef1810). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.9059% <0.0000%> (?)
dm 51.1026% <0.0000%> (?)
engine 63.4373% <0.0000%> (?)
Flag Coverage Δ
unit 57.4885% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11390   +/-   ##
================================================
  Coverage               ?   57.4885%           
================================================
  Files                  ?        853           
  Lines                  ?     126086           
  Branches               ?          0           
================================================
  Hits                   ?      72485           
  Misses                 ?      48211           
  Partials               ?       5390           

@asddongmen
Copy link
Contributor

/retest

1 similar comment
@asddongmen
Copy link
Contributor

/retest

Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2024
@asddongmen
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

1 similar comment
@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
@ti-chi-bot ti-chi-bot closed this Aug 5, 2024
@asddongmen asddongmen reopened this Aug 5, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 8ee0f37 into pingcap:release-8.1 Aug 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants