-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processor: fix a bug that will cause processor Tick get stuck when downstream is Kafka (#11339) #11390
processor: fix a bug that will cause processor Tick get stuck when downstream is Kafka (#11339) #11390
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: dongmen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #11390 +/- ##
================================================
Coverage ? 57.4885%
================================================
Files ? 853
Lines ? 126086
Branches ? 0
================================================
Hits ? 72485
Misses ? 48211
Partials ? 5390 |
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…11339-to-release-8.1
/retest |
1 similar comment
/retest |
/retest |
This is an automated cherry-pick of #11339
What problem does this PR solve?
Issue Number: close #11340
What is changed and how it works?
Check List
Tests
Deploy a cdc cluster, create two changefeeds and synchronize the same table to both Kafka and TiDB separately.
Every 20 minutes, inject CDC to network isolation:
Repeat this process six times.
Before this PR, the lag in the MySQL sink changefeed was influenced by the Kafka sink changefeed when network isolation was introduced between CDC and Kafka:

After this PR, only Kafka sink changefeed lag increasing during network isolation injection:

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note