-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processor: fix a bug that will cause processor Tick get stuck when downstream is Kafka #11339
Conversation
Signed-off-by: dongmen <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
This reverts commit 5014fee.
/test all |
Signed-off-by: dongmen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11339 +/- ##
================================================
- Coverage 57.6147% 57.5747% -0.0401%
================================================
Files 849 849
Lines 126294 126262 -32
================================================
- Hits 72764 72695 -69
- Misses 48121 48155 +34
- Partials 5409 5412 +3 |
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #11340
What is changed and how it works?
Check List
Tests
Deploy a cdc cluster, create two changefeeds and synchronize the same table to both Kafka and TiDB separately.
Every 20 minutes, inject CDC to network isolation:
Repeat this process six times.
Before this PR, the lag in the MySQL sink changefeed was influenced by the Kafka sink changefeed when network isolation was introduced between CDC and Kafka:

After this PR, only Kafka sink changefeed lag increasing during network isolation injection:

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note