Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

least/greatest function for string #6662

Merged
merged 23 commits into from
Feb 8, 2023
Merged

least/greatest function for string #6662

merged 23 commits into from
Feb 8, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Jan 19, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6660

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • gengliqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 19, 2023
Lloyd-Pottiger
Lloyd-Pottiger reviewed Jan 19, 2023
View reviewed changes
dbms/src/Flash/Coprocessor/DAGUtils.cpp Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
yibin87
yibin87 reviewed Jan 29, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add fullstack sql test please.

dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
@ywqzzy ywqzzy changed the title least/greast function for string least/greatest function for string Jan 29, 2023
@ywqzzy ywqzzy force-pushed the least_greatest_string branch from 337b187 to 3ff83b4 Compare February 7, 2023 01:08
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 7, 2023

/run-all-tests

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 7, 2023

/run-unit-tests

@ywqzzy ywqzzy requested a review from xzhangxian1008 February 7, 2023 05:13
gengliqi
gengliqi reviewed Feb 7, 2023
View reviewed changes
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
xzhangxian1008
xzhangxian1008 reviewed Feb 7, 2023
View reviewed changes
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor

lgtm

SeaRise
SeaRise approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by xzhangxian

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2023
gengliqi
gengliqi approved these changes Feb 8, 2023
View reviewed changes
dbms/src/Functions/LeastGreatest.h Outdated Show resolved Hide resolved
dbms/src/Functions/LeastGreatest.h Outdated
}

// 3B. merge result columns of const columns and result_col
if (string_columns_size == 1 && !const_columns.empty())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to upper if (string_columns_size == 1) ? Actually, if string_columns_size is 1, const_columns must be non-empty because the arguments size is greater than 2.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2ccea27

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 8, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@ywqzzy ywqzzy force-pushed the least_greatest_string branch from 3931557 to b51b895 Compare February 8, 2023 09:11
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 8, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b51b895

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 8, 2023

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit f147859 into pingcap:master Feb 8, 2023
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Feb 10, 2023
@ywqzzy @guo-shaoge
least/greatest function for string (pingcap#6662)
a6daf46 
close pingcap#6660
ywqzzy added a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@ywqzzy
least/greatest function for string (pingcap#6662)
4e8d098 
close pingcap#6660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger left review comments

@SeaRise SeaRise SeaRise approved these changes

@gengliqi gengliqi gengliqi approved these changes

@yibin87 yibin87 Awaiting requested review from yibin87

@xzhangxian1008 xzhangxian1008 Awaiting requested review from xzhangxian1008

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support least/greatest(string, string....) function pushdown
7 participants
@ywqzzy @ti-chi-bot @xzhangxian1008 @yibin87 @gengliqi @SeaRise @Lloyd-Pottiger